Remove fClient

7 messages GitHub Pieter Wuille, Gavin Andresen, Jeff Garzik, BitcoinPullTester January 9, 2013 — January 14, 2013

sipa January 9, 2013 18:42 UTC Source · Permalink

Client (SPV) mode never got implemented entirely, and whatever part was already working, is likely not been tested (or even executed at all) for the past two years. This removes it entirely.

If we want an SPV implementation, I think we should first get the block chain data structures to be encapsulated in a class implementing a standard interface, and then writing an alternate implementation with SPV semantics.

gavinandresen January 9, 2013 20:57 UTC Source · Permalink

ACK, but I think you should collapse the empty curly braces.

sipa January 9, 2013 21:34 UTC Source · Permalink

@gavinandresen done

Jeff Garzik (jgarzik) January 9, 2013 21:41 UTC Source · Permalink

ACK

Jeff Garzik (jgarzik) January 9, 2013 21:42 UTC Source · Permalink

I was thinking that we should archive satoshi code snippets somewhere, perhaps in contrib/

He did a bit of fClient work, emailed some code snippets to others, etc. Would be nice to collect the Not Used Yet ones, and not bury them in email boxes or git history.

BitcoinPullTester January 9, 2013 21:45 UTC Source · Permalink

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c2b72ba27f0b41d15c70818cb974d4fe7188d17c for binaries and test log.

gavinandresen January 14, 2013 19:41 UTC Source · Permalink

@jgarzik : the fClient work is in the ‘blockheaders’ branch here. The only code snippet I got from Satoshi is now merged (the signature cache).