Build error SVN r115 on my Mac: workaround

3 messages BitcoinTalk Gavin Andresen, Satoshi Nakamoto July 28, 2010 — July 28, 2010
Gavin Andresen July 28, 2010 15:18 UTC Source ·

I get:

/var/folders/n7/n7Do3Krz2RWPeE+1YxvhUU+++TM/-Tmp-//cc8PgHsQ.s:879:suffix or operands invalid for `call'
... compiling cryptopp/sha.cpp (latest SVN source) on my Mac (gcc version 4.2.1).

I fixed it by adding -DCRYPTOPP_DISABLE_ASM to my makefile; perhaps somebody with more experience compiling C++ on a Mac can figure out a better fix.

Satoshi Nakamoto July 28, 2010 21:23 UTC Source ·

Was that the only thing I broke in the OSX build?!  Does it actually work after just that one change?

I had to do that for makefile.vc also.  It compiled, but SHA-256 didn’t work correctly; it returned the same incorrect hash each time.

We’ll disable it now, and if anyone figures out how to fix it, we can re-enable it then.  It’s still 1.7x faster from the midstate optimisation.

The Crypto++ ASM SHA-256 works with GCC on Linux and Windows (MinGW).

I uploaded this makefile.osx change to SVN.  (let me know if that compiles now)

Gavin Andresen July 28, 2010 21:40 UTC Source ·
Quote from: satoshi on July 28, 2010, 9:23:23 PM UTC

Was that the only thing I broke in the OSX build?! Does it actually work after just that one change?

I built a TEST-network bitcoind with the SVN r115 changes merged in, and yes, after that one change it’s been happily generating coins all afternoon. I don’t use the stock makefile.osx, though— I setup the dependency directory structure a little differently (for no really good reason).